Convert to multitarget netstandard2.0 + net45

fsprojects / FSharpx.Async

Asynchronous programming utilities for F#

http://fsprojects.github.io/FSharpx.Async/

Other

94 stars 31 forks source link

Convert to multitarget netstandard2.0 + net45 #43

Closed Szer closed 5 years ago

Szer commented 6 years ago

I've tried to convert whole process to modern way:

Added multi target build:
- old net45 dependencies lives under Legacy build group
Integrated SourceLink
Switched to XUnit (it was just easier to configure for netcoreapp + paket)
Cleaned up fsproj files
Added explicit dependencies to paket.template file
A lot of small fixes in build scripts
The only place where I've changed source files are here (with conditional compilation):
- AsyncStream
- AsyncOperations

Szer commented 6 years ago

Currently Travis fails only because it tries to test project with NUnit.

XUnit works fine from FAKE script:

Szer commented 6 years ago

Forgot that Ubuntu paths are case-sensitive :) Now it builds everywhere

panesofglass commented 5 years ago

@fsprojectsgit or @forki, could you please merge this or #38?

panesofglass commented 5 years ago

@Szer, thank you for your PR, and apologies it has taken so long for someone to reply. I'd like to close this in favor of #38, though #38 needs some changes. Would you be interested in reworking your changes to build on top of #38?

panesofglass commented 5 years ago

Merged into #