search

fsprojects / FSharpx.Collections

FSharpx.Collections is a collection of datastructures for use with F# and C#.
http://fsprojects.github.io/FSharpx.Collections/
Apache License 2.0
247 stars 78 forks source link

Expose PersistentVector.rangedIterator #167

Closed simendsjo closed 3 years ago

simendsjo commented 3 years ago

PersistentVector.toSeq gives all elements, but selecting just a subset is more performant.

simendsjo commented 3 years ago

My bad. Never used expecto before. I saw a green line locally and interpreted it as "all green", but it actually says "4 errored" in the message. It's the out of bounds checking - I thought it was strange behavior to have, so them failing is actually good :) I'll fix the PR later.

simendsjo commented 3 years ago

Looks like some unrelated problems in the Mac build.

The failure

Error: mpdecimal: no bottle available!
You can try to install from source with:
  brew install --build-from-source mpdecimal

But there is also a warning:

Warning: You are using macOS 10.13.
We (and Apple) do not provide support for this old version.
You will encounter build failures with some formulae.
jackfoxy commented 3 years ago

Sorry, I'm no help with Mac issues.

simendsjo commented 3 years ago

Sorry, I'm no help with Mac issues.

I don't know anything about Mac myself. Guessed it might be travis related, and found this issue: https://travis-ci.community/t/the-default-osx-image-xcode9-4-is-now-unusable-because-macos-10-13-is-eol/10628

Added a new commit to use the newest version.

jackfoxy commented 3 years ago

Did you read my prior message?

simendsjo commented 3 years ago

Did you read my prior message?

I did, but didn't think it would block this PR as it's unrelated. But I moved the commit which fixes your build to a separate PR: https://github.com/fsprojects/FSharpx.Collections/pull/168 (Which means this PR will fail for Mac until that PR is merged)

jackfoxy commented 3 years ago

@simendsjo sorry for the delay. I trust both your PRs are good, so I'm accepting them, despite my being hampered still by this problem https://github.com/fsprojects/FSharpx.Collections/issues/164#issuecomment-803452888