search

fsprojects / FSharpx.Collections

FSharpx.Collections is a collection of datastructures for use with F# and C#.
http://fsprojects.github.io/FSharpx.Collections/
Apache License 2.0
247 stars 78 forks source link

Include source files in the Nuget package #185

Closed bergmannjg closed 2 years ago

bergmannjg commented 3 years ago

Description

Please include the source files in the Nuget package to make the library compatible with the dotnet Fable tool.

A corresponding rule can be added to the files block in the paket.template file.

njlr commented 2 years ago

I think this library is already (somewhat) Fable compatible? Which version are you using?

See: https://github.com/fsprojects/FSharpx.Collections/blob/master/src/FSharpx.Collections/FSharpx.Collections.fsproj#L15

bergmannjg commented 2 years ago

I am using the nuget package version 3.0.1, which contains no fable folder.

The content itemgroup in FSharpx.Collections.fsproj is used by dotnet pack, but the nuget package is built with paket.

See: https://github.com/fsprojects/FSharpx.Collections/blob/master/build.fsx#L126

njlr commented 2 years ago

Ah I see!

This should fix it: https://github.com/fsprojects/FSharpx.Collections/pull/187

bergmannjg commented 2 years ago

Thanks

njlr commented 2 years ago

Will take a while for the review, merge, release cycle to complete (I don't have permissions)