search

fsprojects / FSharpx.Collections

FSharpx.Collections is a collection of datastructures for use with F# and C#.
http://fsprojects.github.io/FSharpx.Collections/
Apache License 2.0
247 stars 78 forks source link

Fix RunTests fake target #192

Closed gdziadkiewicz closed 2 years ago

gdziadkiewicz commented 2 years ago

Path in RunTests used net6 while the test projects compile to net5. As a result, no tests were executed. I propose we bump the tests to net6 due to net5 being eovs, but in a different PR after making what we have work.

gdziadkiewicz commented 2 years ago

The build is failing due to missing net5 runtime necessary to run the tests https://github.com/fsprojects/FSharpx.Collections/actions/runs/3043431021/jobs/4902688249#step:7:333 image

gdziadkiewicz commented 2 years ago

Before (on master, tests not detected): https://github.com/fsprojects/FSharpx.Collections/actions/runs/2818063133/jobs/4449675536#step:7:331 image

After (PR build, tests executed): https://github.com/fsprojects/FSharpx.Collections/actions/runs/3059060345/jobs/4935993432#step:7:330 image

gdziadkiewicz commented 2 years ago

@sergey-tihon would you be able to check?

sergey-tihon commented 2 years ago

fix in master