fsprojects / FSharpx.Extras

Functional programming and other utilities from the original "fsharpx" project
https://fsprojects.github.io/FSharpx.Extras/
The Unlicense
682 stars 146 forks source link

Fix build script #277

Closed DanielFabian closed 9 years ago

DanielFabian commented 10 years ago

trying to run the build.bat file on our build agent yields the following errors.

[06:05:54][Step 1/1] 
[06:05:54][Step 1/1] 
[06:05:54][Step 1/1] build.fsx(102,8): warning FS0044: This construct is deprecated. !+ is obsolete - use !! instead
[06:05:54][Step 1/1] 
[06:05:54][Step 1/1] 
[06:05:54][Step 1/1] build.fsx(113,8): warning FS0044: This construct is deprecated. FileIncludes implement     IEnumerable<string> so explicit scanning is not needed
[06:05:54][Step 1/1] 
[06:05:54][Step 1/1] 
[06:05:54][Step 1/1] build.fsx(113,8): error FS0001: Type mismatch. Expecting a
[06:05:54][Step 1/1]     FileIncludes -> seq<'a>    
[06:05:54][Step 1/1] but given a
[06:05:54][Step 1/1]     FileIncludes -> FileIncludes    
[06:05:54][Step 1/1] The type 'seq<'a>' does not match the type 'FileIncludes'
forki commented 10 years ago

we are working on thisw, but it needs time and there is more than this simple problem.

sri-prasanna commented 10 years ago

hi @forki, just wanted to know on why we could not fix this bug by updating the else clause in the appReferences function in build.fsx to something like this:

    seq { (!! "./src/**/*.*proj") with 
        Excludes = 
            [yield "./src/**/*.Silverlight.*proj"
             if not (buildTypeProviders frameworkVersion) then                
                yield "./src/**/*.TypeProviders.*.*proj"
                yield "./src/**/*.TypeProviders.*proj"
             if frameworkVersion = net35 then 
                yield "./src/**/*.Async.fsproj"
                yield "./src/**/*.Http.fsproj" // TODO: why is that?
                yield "./src/**/*.Observable.fsproj" // TODO: why is that?
                    ] }
    |> Scan
forki commented 10 years ago

You can send a pull request if this helps you. No problem, but things will change soon.

fsgit commented 9 years ago

This has been fixed