search

fsprojects / FSharpx.Extras

Functional programming and other utilities from the original "fsharpx" project
https://fsprojects.github.io/FSharpx.Extras/
The Unlicense
682 stars 146 forks source link

update FSharpx.Async to 1.14.1 and FSharpx.Collections to 2.0.0 in paket.lock #373

Closed eriawan closed 4 years ago

eriawan commented 5 years ago

Update these dependencies: FSharpx.Async to 1.14.1 and FSharpx.Collections to 2.0.0 in paket.lock

eriawan commented 5 years ago

@panesofglass

Related to issue #370 particularly this comment: https://github.com/fsprojects/FSharpx.Extras/issues/370#issuecomment-518284931 Could you please review?

panesofglass commented 5 years ago

Thank you, @eriawan!

panesofglass commented 5 years ago

Unfortunately, there are changes in the dependencies that make it more complicated than just updating versions.

eriawan commented 5 years ago

@panesofglass

Unfortunately, there are changes in the dependencies that make it more complicated than just updating versions.

Changes in dependencies? Please elaborate.

panesofglass commented 5 years ago

@eriawan, FSharp.Core 4.6.2 is now required. There were several other changes that popped up when I ran paket update on each of the dependencies mentioned in this issue, as well. Also, the ByteString module is now marked as RequireQualifiedAccess, so that had to be updated where used.

eriawan commented 4 years ago

@panesofglass

Thanks for the update and the merge! I had tried to solve this myself but I was so confused myself. Does this mean now FSharp.Async is ready to be released to nuget?

panesofglass commented 4 years ago

@eriawan, I think FSharpx.Async should already be updated. Is something more needed?

eriawan commented 4 years ago

@panesofglass

I think FSharpx.Async should already be updated. Is something more needed?

Thanks for pointing that! 🙂 👍 Yes, it has been updated. I was thinking and wondering before, that we should ensure FSharpx.Async be in sync with the one that we have now, including the necessary dependencies. After looking at the current state of FSharpx.Async, we are good. Apologize if I might add more confusion to you.

Our FSharpx.Extras is in good condition again now.