Using System.Json 4.5.0

[wallymathieu]

• [x] Look into if there is a better way than catching System.InvalidCastException
• [x] Guid: "Expected Guid, actual Error: Operation is not valid due to the current state of the object." from 00000000-0000-0000-e7ac-78ee10864b17

This fixes #29 This fixes #49

[wallymathieu]

Well, since I can't run the tests locally the "This fixes #29" was premature. However, it does compile, so someone, perhaps @harrisonmeister, could take it further and make a new PR.

[harrisonmeister]

@wallymathieu - I'm a bit busy atm but will certainly try take a look at your changes and will raise a PR if I can get it working.

[wallymathieu]

The prio is probably low, so no stress.

[harrisonmeister]

@wallymathieu - this compild and ran locally for me (i needed the path to msbuild in my PATH env variable). I couldnt find a way to get the tests to run within VS2017, and they dont appear in the build.bat script.

@gusty - are there any tips to getting the tests to run?

[harrisonmeister]

Ah, saw this in the appveyor script. dotnet run --project .\Tests\Tests.fsproj --framework net461 😆

[wallymathieu]

@harrisonmeister I've tried to fix some of the issues, could you look at my fixes? Perhaps suggestions for improvements?

[gusty]

@wallymathieu Maybe you can do a [WIP] PR so @harrisonmeister can reference the package in his project and test it (via Appveyor artifact).

[wallymathieu]

I've changed the title and added an #if SYSTEMJSON

[wallymathieu]

Looks like some of the behavior is intentional. I tried adding a few tests, but noticed that there are some tests of the existing behavior: https://github.com/dotnet/corefx/pull/32418

[gusty]

@harrisonmeister @BlythMeister I just released a new version with this PR.

It will live now in its own namespace and its nuget will be this: https://www.nuget.org/packages/Fleece.SystemJson

Notice there are some breaking changes (mainly the namespace and the dll), but there are also lots of new features. See the release notes.

In case you decide to migrate to this version, feedback will be much appreciated.

Otherwise you can stick to old Fleece nuget, v. 0.6.0, but it won't be further maintained.

[harrisonmeister]

@gusty - thanks for this. We try to update our nuget oss dependencies often typically once a month. We have just finished our last one a couple of days ago, so I'll try to get this new package in with our next months release and let you know how we get on.

Thanks, Mark

[gusty]

Thanks @harrisonmeister so based on the release notes when you migrate to Fleece.SystemJson 0.7.0 all you'll have to do is:

• Change the nuget from Fleece to Fleece.SystemJson
• Change namespace Fleece to Fleece.SystemJson
• Change Success and Failure to Helpers.Success and Helpers.Failure

Hopefully it works fine for you !

[harrisonmeister]

Hi @gusty - no worries, thanks for the update! 👍