fsprojects / Fleece

Json mapper for F#
http://fsprojects.github.io/Fleece
Apache License 2.0
199 stars 31 forks source link

add map, apply, alternative versions of operators #66

Closed 7sharp9 closed 5 years ago

wallymathieu commented 5 years ago

Looks good, I guess the intent here is to present these as module functions for ConcreteCodec?

gusty commented 5 years ago

To me the argument order is a bit unexpected. I'll be in favor of renaming them, for instance map with arguments flipped is called for in Haskell, though here it's a reserved word.

wallymathieu commented 5 years ago

I didn't notice the argument order. Could it be that the argument order was unintentional? @7sharp9

gusty commented 5 years ago

No, it was intentional in order to be able to construct idioms for applicatives/alternatives using forward pipe instead of other operators.

He needed for Falanx, but apparently he solved the operator restriction already.

wallymathieu commented 5 years ago

Should this PR be closed? @7sharp9

gusty commented 5 years ago

Yes