Not escaped query value part

[maciej-izak]

Hi,

I have prepared PR : https://github.com/fsprojects/FsHttp/pull/117 . This is because during work with FsHttp I found that using library in such way :

let resp =
    http {
        GET "https://someurl"
        query [
            "limit", 1000
            "rule", foo
            "orderBy", "DateAddedDesc"
            "APIKEY", APIKEY
        ]
        CacheControl "no-cache"
    }
    |> Request.send

is very error prone. This is because value part is not escaped.

Workaround (but IMO this should be default behavior) :

let escape = List.map (fun (k, v: obj) -> k, box (Uri.EscapeDataString $"{v}"))
let resp =
    http {
        GET "https://someurl"
        query (escape [
            "limit", 1000
            "rule", foo
            "orderBy", "DateAddedDesc"
            "APIKEY", APIKEY
        ])
        CacheControl "no-cache"
    }
    |> Request.send

[SchlenkR]

I'll have a look at it soon. Please excuse the late reply - your work is very much appreciated!

[SchlenkR]

but IMO this should be default behavior

I think so, too. Closing this as PR is merged.

And of course: Thank you very much for your PR :)