search

fsprojects / FsHttp

A lightweight F# HTTP library by @SchlenkR and @dawedawe
https://fsprojects.github.io/FsHttp/
Apache License 2.0
424 stars 42 forks source link

Fix implicit dependency on FSharp.Core #177

Closed dawedawe closed 4 months ago

dawedawe commented 5 months ago

fixes #176

SchlenkR commented 4 months ago

Just to clarify: Will this change (having FsHttp reference F# Core 8) be working for FsHttp users targeting combinations of dotnet SDK / F# with versions lower than 8?

dawedawe commented 4 months ago

Just to clarify: Will this change (having FsHttp reference F# Core 8) be working for FsHttp users targeting combinations of dotnet SDK / F# with versions lower than 8?

The combinations should still work as before. I checked with a project having TargetFramework = net6.0 and a local nuget source. We are already doing this for FsHttp.FSharpData. The explicit dependencies of FsHttp.FSharpData can also be seen here The FsHttp package shows the missing explicit dependency here, that should be fixed with 14.4.1.

SchlenkR commented 4 months ago

Thank you so much for taking your time @dawedawe for trying out and sharing, and the PR. Great stuff!