FSharp.Core dependency confusion

fsprojects / FsHttp

HTTP library fir F#

https://fsprojects.github.io/FsHttp/

Apache License 2.0

445 stars 43 forks source link

FSharp.Core dependency confusion #183

Closed bartelink closed 7 months ago

bartelink commented 7 months ago

14.4.1 specifies that the package depends on FSharp.Core v8 14.4.0 (and ones before that for quite a bit) omits it

Problem is that an app of mine had a FSharp.Core ~> 7 in it's paket.dependencies.

Paket correctly says "well the latest I can give you is 14.4.0, which doesnt even require FSharp.Core`

bartelink commented 7 months ago

@SchlenkR Preparing a PR to downgrade FSharp.Core dep as much as possible on the basis that this triggers people updating FSharp.Core prematurely for no benefit (I tend to have my libs depend on 6.0.7 as it fixes a key Async.Parallel bug that can core dump the process)

Please let me know asp if you're not going to accept it...

bartelink commented 7 months ago

cc @dawedawe I see you added it; perhaps you have insight/preferences wrt the version?

(Also apologies for the atting, but this seems like a quick fix, and the state of affairs burned some engineering time our side hence the overreaction - you can regularly see me chewing people out of it for atting Nick in the Serilog repos; a clear case of do as I say, not as I do!)

SchlenkR commented 7 months ago

FSharp.Core is pinned to 5.0.2 (>5 required for string interpolation; >5.0.2 required by FSharp.Data).
Test projects (basically an application, targeting only the latest .Net version) don't reference FSharp.Core at all.
No refs in build props!

Links:

(Guidance for package authors

Package authors should pin their FSharp.Core reference

Hint:

Instead of "Update", we use "Include" - don't ask me why, but that seems to work; update not.

I'll release 14.4.2 now...

bartelink commented 7 months ago

Thanks, this is great - packages / paket update passes the sniff test so closing. Will report back here if there turns out to be any issues (not expecting any)