search

fsprojects / FsLexYacc

Lexer and parser generators for F#
http://fsprojects.github.io/FsLexYacc/
MIT License
203 stars 68 forks source link

Add case insensitive option. #130

Closed gdziadkiewicz closed 3 years ago

gdziadkiewicz commented 3 years ago

Fix #102

gdziadkiewicz commented 3 years ago

@dsyme could you label this PR as hacktoberfest-accepted (details: https://hacktoberfest.digitalocean.com/hacktoberfest-update)?

dsyme commented 3 years ago

Done thanks

dsyme commented 3 years ago

@gdziadkiewicz is this ready? It looks ok

gdziadkiewicz commented 3 years ago

Yes

dsyme commented 3 years ago

@gdziadkiewicz I took a look but couldn't quite work out what the testing was doing - could you either add more tests showing the case insensitivity, or explain the tests you have?

thanks

gdziadkiewicz commented 3 years ago

I added 2 new inputs - input3 and input4 (same as input3, but using PoKeMoN case for keywords let, in and and). In the added test they both use the same expected output to show that the generated parser is case insensitive.

gdziadkiewicz commented 3 years ago

@dsyme I added comments to describe the testing approach. Please check if this is sufficient.

dsyme commented 3 years ago

Cool, I didn't spot the LeT

If you want to go further you could add some tests involving the Turkish i :-) Though read this carefully :-)

https://web.archive.org/web/20171001054928/https://msdn.microsoft.com/en-us/library/ms973919.aspx#stringsinnet20_topic5