break out core domain logic and generation into core libraries

baronfel commented 3 years ago

Woo boy this does a lot of things in service of #143

Breaks out the logics in the two driver applications into two core libraries, one for each application
Updates packaging to pack and publish the new packages as well, adding in sourcelink as well!
maintains the existing meta-package
adds in domain-level unit tests (should be fleshed out)
pushes out all mutable state from the driver applications into state structures that can be passed in to calls to the 'core' logics

the aim is to make the .Core packages something that could be embedded in other applications (especially IDE tooling) to make working with fslex/fsyacc files nicer.

I'd expect shortly after these changes to do a pass on the returned data model in the various specs to provide ranges, not just positions, for the structures.

dsyme commented 3 years ago

Looks good!

baronfel commented 3 years ago

This is green! I want to rebase it into less messy history, but then I think this is ready for review and potential merge.

dsyme commented 3 years ago

This looks totally fine. I'll just squash merge if you wish?

baronfel commented 3 years ago

Squash merge was basically what I was going to do locally, so that's fine with me.

dsyme commented 3 years ago

I believe it's because we're not internalizing the FsLexYacc.Runtime anymore, and instead making it a normal project reference

OK

dsyme commented 3 years ago

Done :-)

teo-tsirpanis commented 3 years ago

You have kept the auto-generated FsLex/FsYacc source files @baronfel. Is that intentional?

fsprojects / FsLexYacc

break out core domain logic and generation into core libraries #144