search

fsprojects / FsLexYacc

Lexer and parser generators for F#
http://fsprojects.github.io/FsLexYacc/
MIT License
207 stars 69 forks source link

Reactivate legacy unicode test, test2 and add Expecto tests to build pipeline #157

Closed gdziadkiewicz closed 2 years ago

gdziadkiewicz commented 2 years ago

Based on the content of build.bat and run.bat files left after legacy tests I was able to find out how to use some of the legacy tests marked as incomplete (I was mostly interested in Unicode tests). While working on it I managed to get rid of the distinction between main and main-unicode and to remove usages of ml and some of the OCaml adapters.

As for the Expecto tests I decided to go with YoloDev.Expecto.TestSdk because it allowed to easily run the tests in the pipeline via dotnet test and as a bonus allows to run them in VS:

image
baronfel commented 2 years ago

I love the addition of the test suite! Looking forward to seeing this green :)

gdziadkiewicz commented 2 years ago

I believe that this is ready to be reviewed and merged if there are no issues.

gdziadkiewicz commented 2 years ago

@dsyme would you find a moment to review?

gdziadkiewicz commented 2 years ago

@baronfel @kkm000 are you perhaps able to review?

dsyme commented 2 years ago

Looks good to me!