Open haf opened 7 years ago
What's the way to test if what I've done works? There are no docs what so ever about how to run this thing in dev mode...?
good question. did not do this for very long time.
probably by copying things manually in place
While you have a look at that, here are the main changes:
./dist
./dist/index.html
which is where https://github.com/ampedandwired/html-webpack-plugin puts it after injecting all the required JStemplate.js
which enabled me to move all logic out of the HTML file.This will make it:
QA needed on:
Help needed on:
AFK for a while now; I need to write my presentation too. Which btw I could hold for the F# community too; intro to Kafka.
upgrading reveal was always easy.
https://github.com/fsprojects/FsReveal/blob/develop/paket.dependencies#L6 so it was only a git push on the reveal clone (please note we explicitly maintain the fork, since we often are a couple of commits in front of reveal.js master)
I did notice a strange reveal.js-[GITHASH]
folder in the fork; is that where you want me to use the files from? Why not just merge it into the files of the actual repo?
suave is taken via paket from nuget.
@kimsk @troykershaw What css file am I missing? Only getting white BG:
It looks like the reveal.js
css theme is missing. Those files are something like css/theme/night.css
in reveal.js
.
@kimsk Thanks; the last two issues are:
showTip
/hideTip
are expected to be globals, rather than composed functions – I've placed the tips.js file inside the bootstrapping file but haven't found where they are being used (need to get on with presentation now!). Any direction towards fixing that would be excellent.O
and then right arrow twice:I've just tested this on my MacBook, and here are my findings:
build.cmd
or build.sh
before running yarn run build
. If you don't do that, you get errors like the following error:ERROR in ./template.js Module not found: Error: Cannot resolve 'file' or 'directory' ../../paket-files/fsprojects/reveal.js/css/reveal.css in /Users/erikschierboom/Programming/FsReveal/src/FsReveal @ ./template.js 3:0-64 43:2-66
Having run build.sh
first and then the yarn
commands fixes it.
The README doesn't mention the fact that you can run in watch mode using yarn run watch
If I open the dist/index.html
file after successfully building, it unfortunately doesn't work. It complains that three files cannot be found:
dist/css/custom.css
common.<..>.js
app.<..>.js
You need to run Suave like in my screenshots above... Could you do that?
@haf Sorry, but how do I do that? If I run a local node http-server
, things don't work:
I'm a bit confused a to why Suave would be necessary. Wasn't the whole point being that it could run offline?
Yes, it runs offline from the point of view of your laptop. Just because we start a local web server, we don't have internet.
Today we can't show the presentation without internet.
I'll see what I can whip together in the form of a readme.
@haf Okay, clear. But shouldn't running http-server
in the dist
directory be working? In my screenshot above, you can see that it didn't.
A readme would be much appreciated!
I've updated the READMEs with that information now @ErikSchierboom
How to test:
check out the two branches. First build this PR with ./build NuGet
then add paket.local
in the other PR (see README.md
) to point to the new nuget, then do .paket/paket.exe restore
to use it. Now you can run ./build
in the other PR to run the server.
I think it's worth merging now and fixing remaining issues together with the community: e.g. the pretty-printed code lines being slightly off, bumping reveal.js
in the fsprojects
org and going through its themes, removing downloads from googleapis.com
. Also themes and speaker notes aren't really working, but now I have to write my presentation! :)
Thanks @haf!
Any chance of this?
Need someone to pick up the slack. I don't have the bandwidth to complete this refactor (but it's working now, so someone just needs to merge it and test it in full)
The aim of the PR is to make FsReveal function without internet access. This means we need to pull in all of the code as a single compilation unit: