search

fsprojects / FsReveal

FsReveal parses markdown and F# script file and generates reveal.js slides.
http://fsprojects.github.io/FsReveal
258 stars 102 forks source link

modified generated HTML files by downloading CDN-loaded assets #105

Closed wki closed 2 years ago

wki commented 7 years ago

Hi,

maybe I am doing something wrong. But when opening generated HTML files in the output-directory directly in a browser fails because some JavaScript or CSS Assets are loaded without a protocol. This requires being online when viewing a presentation and requires starting a server.

By downloading all CDN-loaded assets into the output-directory, all presentations may be viewed offline and without running a web server.

This simple patch modifies the HTML files after their generation. Maybe not perfect but usable.

Forgive me if my beginners-F#-Style is not perfect, too.

isaacabraham commented 7 years ago

This would be awesome, it's something I've wanted solved for ages!

forki commented 7 years ago

@haf howdoes this relate to your recent work?

haf commented 7 years ago

It's duplicate work to my PR.

wki commented 7 years ago

if this thing will be solved by another PR, then please silently ignore my PR.

haf commented 7 years ago

@wki I think the only part left for the other #104 PR to merge is a review actually... I was like a truck truckin' along that ran out of gas and needs to get some help to go to the finish line ;) If you'd be up for it, it would be much appreciated.