search

fsprojects / FsReveal

FsReveal parses markdown and F# script file and generates reveal.js slides.
http://fsprojects.github.io/FsReveal
258 stars 102 forks source link

C/AL #76

Closed forki closed 9 years ago

forki commented 9 years ago

I updated to latest FSharp.Formatting but it didn't really work

image

image

/cc @tpetricek @kfuglsang

tpetricek commented 9 years ago

Yeah, this is where the two syntax highlighters start fighting each other.

I think we need to do what @kfuglsang suggested - disable the one in FsReveal on everything that has been highlighted by F# Formatting and probably fix the CSS for C/AL formatting....

kfuglsang commented 9 years ago

I just took a look at this. We need a way to figure if FSharp.Formatting did the formatting already. Otherwise we would have to exclude all the languages that FSharp.Formatting supports - but that's not nice in the long run.

I'm working on a solution.

forki commented 9 years ago

Much better, but still no touchdown. I think the font size is wrong. Ideas?

image

image

image

kfuglsang commented 9 years ago

Looks good with https://github.com/fsprojects/FsReveal/pull/78 :)

forki commented 9 years ago

mhm. it's still a bit of

kfuglsang commented 9 years ago

Looks like this on my machine.

image

image

image

forki commented 9 years ago

mhm that looks awesome. but why is it not working on my machine!?

kfuglsang commented 9 years ago

Which browser?

I checked in both Chrome and IE 11

forki commented 9 years ago

yep. looks broken in both browsers. So I assume there is something else fucky. Maybe the copy did not work and one of us is seeing a different css file?

2015-06-14 18:10 GMT+02:00 Kenneth Fuglsang Christensen < notifications@github.com>:

Which browser?

I checked in both Chrome and IE 11

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/FsReveal/pull/76#issuecomment-111843612.

forki commented 9 years ago

it's also misaligned on my other machine

forki commented 9 years ago

image

forki commented 9 years ago

I found it

kfuglsang commented 9 years ago

Cool.

forki commented 9 years ago

works

IT WORKS!!! AWESOME! Thank you so much for making this happen.

kfuglsang commented 9 years ago

No problem! ;-)

forki commented 9 years ago

https://twitter.com/sforkmann/status/610126276498706432

tpetricek commented 9 years ago

Looks good - although can we fix the CSS so that the background color is the same in the table cell with the code and the table cell with the line numbers? (I think it used to be the same before...)