search

fsprojects / FsXaml

F# Tools for working with XAML Projects
http://fsprojects.github.io/FsXaml/
MIT License
172 stars 48 forks source link

Provided a more detailed exception message when .xaml files aren't set to Resource #10

Closed kevlut closed 10 years ago

kevlut commented 10 years ago

This should close issue #8.

In addition, I have also found that if some .xaml files are set to resource and some aren't--i.e. App.xaml is Resource and MainWindow.xaml is set to Content--PresentationFramework will throw the file name of the .xaml file causing issues and the code I added (handling for XamlParseException) will remind user to set all .xaml files to resource.

I plan to write an utility function that will find the exact property and property value causing issues for when an exception message provides a line number and column position of where the stream was when the exception occurred.

ReedCopsey commented 10 years ago

@kevlut The utilities.fs file seems unchanged (other than comments) - Can we change it to not push in a commented out routine?

kevlut commented 10 years ago

Yep, of course. That would make the most sense. Will remember for future PRs. @ReedCopsey I am assuming you mean "we" as in the mods will change to not push the commented out routine. I would also prefer that since I'm not sure how to rollback/undo/not-include that file unless I rollback my commit and submit a new PR; or is that the proper procedure?

ReedCopsey commented 10 years ago

@kevlut Want to update your Pull Request to remove the extra comments?