fsprojects / IfSharp

F# for Jupyter Notebooks
Other
441 stars 71 forks source link

Fix the Red Squigglies #123

Closed sylvanc closed 7 years ago

sylvanc commented 7 years ago

Red squigglies now appear in a manner similar to Ionide.

Typechecking is done:

This gives delayed but constant typechecking.

cgravill commented 7 years ago

Excellent, this definitely reduced the false positive rate of red squiggles on a few cases I tried and makes for a better editing experience.

We are missing some errors that Ionide can project in e.g.

image

vs

image

I'd be happy for this to be merged as it gets right what it does in my interactions. Then later we can decide about covering more cases.

sylvanc commented 7 years ago

Hmm, wonder why it doesn't catch that! Merging, and we can improve it more :)