search

fsprojects / IfSharp

F# for Jupyter Notebooks
Other
441 stars 71 forks source link

fcs 12.0.8 #144

Closed dsyme closed 7 years ago

dsyme commented 7 years ago

cc @sylvanc @cgravill

cgravill commented 7 years ago

Should we be getting FSharp.Core.optdata FSharp.Core.sigdata out of \packages\FSharp.Core?

(just seen the change, great news on optdata and sigdata not being needed now!)

dsyme commented 7 years ago

Should we be getting FSharp.Core.optdata FSharp.Core.sigdata out of \packages\FSharp.Core?

They are still in the package for old compiler versions consuming the package

dsyme commented 7 years ago

Have we seen this CI failure before?

C:\projects\ifsharp\tests\IfSharp.Kernel.Tests\startup(1,1): error FS1108: The type 'ITest' is required here and is unavailable. You must add a reference to assembly 'xunit.abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=8d05b1bb7a6fdb6c'. [C:\projects\ifsharp\tests\IfSharp.Kernel.Tests\IfSharp.Kernel.Tests.fsproj]
sylvanc commented 7 years ago

I can't seem to replicate that CI failure locally. We haven't seen it before.

sylvanc commented 7 years ago

Even after a nuget cache flush, this PR builds and runs fine for me (including being able to load packages in notebooks using paket).

Does anyone have the permissions needed to rerun the CI job? If not, @dsyme can you make a meaningless change to kick CI off again? I'm wondering if there was an intermittent problem.

cgravill commented 7 years ago

I haven't seen that failure before. It reproduces locally for me and I'm investigating it now.

Just triggered a new build.

dsyme commented 7 years ago

@cgravill @sylvanc I just reduced the PR to just be for FCS without the update to xunit 2.2

sylvanc commented 7 years ago

The xunit 2.1 PR also builds and runs fine for me.

sylvanc commented 7 years ago

And passes CI :) Merging now.

cgravill commented 7 years ago

Sounds good, we didn't need to upgrade to xunit 2.2 now. I'll look into that separately.