search

fsprojects / IfSharp

F# for Jupyter Notebooks
Other
442 stars 71 forks source link

Theme cannot be configured #148

Closed alexpolozov closed 6 years ago

alexpolozov commented 7 years ago

Description

IfSharp currently hardcodes the CodeMirror theme for F# as neat, and provides a custom CSS for it. This breaks the standard Jupyter theming ecosystem, which expects the cells to have a top-level .cm-s-ipython class. Because of that, projects like jupyter-themes do not work with F# (even though they work with C#, R, Julia, and other third-party kernels).

Suggestion

Remove the hardcoded theme, and change all .cm-s-neat in custom.css to .cm-s-ipython.

If you agree that this is reasonable, I can easily make a PR.

cgravill commented 7 years ago

Supporting Jupyter themes sounds great. I haven't interacted much with the custom CSS so there might be extra complications e.g. our custom code completion or perhaps that bit of the code is just old. If everything works I'd be very happy to merge this in.

cgravill commented 6 years ago

There have been improvements made to this in #180. Give it a try.

See discussion on #176 where we'd like retain default syntax highlighting.

I'm to revisit this further later but I'll close this for now.