search

fsprojects / IfSharp

F# for Jupyter Notebooks
Other
441 stars 71 forks source link

Added a paket reference to FSharp.Compiler.Tools #160

Closed frelon closed 6 years ago

frelon commented 6 years ago

I needed it in order to build in VS2017

cgravill commented 6 years ago

What happens if you don't have this? I'm able to build without it on a local copy of Visual Studio 15.4.2 but perhaps I have something working around the issue?

frelon commented 6 years ago

I get the following compiler-errors:

1>C:\Code\ifsharp\src\IfSharp.Kernel\Evaluation.fs(43,60): error FS0039: The value, constructor, namespace or type 'Settings' is not defined. 1>C:\Code\ifsharp\src\IfSharp.Kernel\Evaluation.fs(51,72): error FS0039: The type 'InteractiveSession' is not defined in 'Microsoft.FSharp.Compiler.Interactive'.

If I have the FSharp.Compiler.Tools in my local packages catalog it builds fine, but when I clear it and build the solution from scratch it seems Paket doesn't download the package.

cgravill commented 6 years ago

OK, figured out what's going on. I have a local install of some of the F# tools. Your improvement lets us work with the NuGet package which is great.

I also updated the FSharp.Compiler.Tools as there was an issue with /preferreduilang not being set.

I'll merge this by #165 and close this one, thanks.

frelon commented 6 years ago

nice!