search

fsprojects / IfSharp

F# for Jupyter Notebooks
Other
440 stars 71 forks source link

Async display support & examples #184

Closed dgrechka closed 5 years ago

dgrechka commented 5 years ago

The PR adds an ability to asynchronously compute and display Async<_> results. An example of the usage is also included.

See the demo notebook.

Associated with #104.

cgravill commented 5 years ago

This looks excellent, there's a lot of core functionality adjusted. How widely have you tested it? Does it work with Mono?

dgrechka commented 5 years ago

Not yet. I'll run it on Mono and will let you know how is it.

dgrechka commented 5 years ago

@cgravill I ran a bunch of examples on Mono. The examples from introduction notebook work well. I think you are safe to merge.

cgravill commented 5 years ago

The new async functionality looks great and works for me as a second check.

There are a couple of new warnings:

Kernel.fs(309,13): warning FS0193: This expression is a function value, i.e. is missing arguments. Its type is (string * 'a) list -> 'b -> unit.
Kernel.fs(373,23): warning FS0067: This type test or downcast will always hold

the first could be problematic as it prevents the help instructions from displaying. Could you take a look please?

dgrechka commented 5 years ago

You are right! Thanks for spotting it! Fixed now.

cgravill commented 5 years ago

Looks good, I'll merge now (the Travis failure is a network issue)