search

fsprojects / IfSharp

F# for Jupyter Notebooks
Other
442 stars 71 forks source link

only require netcoreapp2.1 #209

Closed dsyme closed 5 years ago

dsyme commented 5 years ago

The code was requiring netcoreapp2.2, this is not ubiquitious yet, so reducing the dependency

rudihorn commented 5 years ago

I've been having issues with IfSharp depending on 2.2.0 rather than 2.2.3, see #203 and #206. I think having functionality is more important than supporting older dotnet core versions. Unless you can find other workarounds for #206.

cgravill commented 5 years ago

@dsyme which platforms are causing issues with netcoreapp2.2? The .NET Core builds aren't fully working yet but we have some libraries moving over to 2.2 that we might be trying to access from notebooks soon.

dsyme commented 5 years ago

I've been having issues with IfSharp depending on 2.2.0 rather than 2.2.3, see #203 and #206. I think having functionality is more important than supporting older dotnet core versions. Unless you can find other workarounds for #206.

Ah ok I see thanks. I'll check the issues, but it's fine to require 2.2 if necessary