search

fsprojects / IfSharp

F# for Jupyter Notebooks
Other
442 stars 71 forks source link

Update README.md #212

Closed dsyme closed 5 years ago

dsyme commented 5 years ago

The notebook server in the docker image requires token or jupyter password authentication. Clarify the instructions

@cgravill Do the other approaches also require the jupyter notebook server token to be entered by the client?

dsyme commented 5 years ago

(@cgravill I removed the table of contents as it's really hard to keep up-to-date, is that ok?)

cgravill commented 5 years ago

Yes, there needs to be a token passed. Usually this is hidden as when you start via a jupyter notebook or equivalent it passes the token into the browser start so it seems hidden to the user.

I don't know if you can arrange for something like this to happen.

cgravill commented 5 years ago

I don't feel strongly about the table to contents. Some new people expressed confusion - they didn't really know what Jupyter was just that they wanted to do things interactively. The table of contents approach seems to have worked well for https://github.com/giraffe-fsharp/Giraffe so I was trying it as a lightweight experiment.

I agree it's a bit of a faff but I didn't really expect this sudden influx of - very welcome - activity. :-)

dsyme commented 5 years ago

@cgravill Thanks - shame that the token is required, but I understand

It seems a port mapping is also always required when starting via docker, which surprised me, i.e. -p 8888:8888 - is that expected?

dsyme commented 5 years ago

Re TOC - yes, understood. @gbaydin and myself will keep refining the getting started experience to make it as simple as possible according to @gbaydin's recent experience with Python

BTW the docker images are pretty big, it will be good to eventually trim them a bit.