Restore open cmd window / performance issue

fsprojects / Paket.VisualStudio

Manage your Paket (http://fsprojects.github.io/Paket/) dependencies from Visual Studio!

MIT License

147 stars 51 forks source link

Restore open cmd window / performance issue #145

Open SuperRoflCopter opened 7 years ago

SuperRoflCopter commented 7 years ago

Hi, Since 0.34.0 there is an issue on project build restore open up a cmd window and the restore operation is much more slower than before (0.33.2, had an issue with intellisense with 0.33.3)

The test was made in a solution with 25 projects and auto-restore off, but a restore operation cmd is open for each project. Each cmd is also taking focus everytime it pop.

I guess it would be safer to go :

startInfo.WindowStyle = ProcessWindowStyle.Hidden;
startInfo.CreateNoWindow = true;

And only one paket restore for the whole thing?

Thomas

forki commented 7 years ago

yes. please send PR. I would release asap

304NotModified commented 7 years ago

forki commented 7 years ago

ok 0.35 should at least not open cmd window. please contribute improvements

forki commented 7 years ago

And only one paket restore for the whole thing?

that's still open

SuperRoflCopter commented 7 years ago

I have done a fix that is doing a restore for all projects --references-file instead of multiple restore for each project on one --references-file. Works way more faster on my solutions.

And sorry I'm bit of a newb with git :(

304NotModified commented 7 years ago

And only one paket restore for the whole thing?

Is this another issue?

@SuperRoflCopter does this need many changes? If only one file needs to be changed, it could be done from the GUI, e.g

If you need more changes, then make a fork and make the changes there. From the fork we could merge the code to here (with a Pull Request)

SuperRoflCopter commented 7 years ago

Thanks, I did the pull request from a fork. And forki did the release. (0.36) Seems to works fine for the devs in my company.

forki commented 7 years ago

Keep them coming ;-)

Am 13.10.2017 18:57 schrieb "SuperRoflCopter" notifications@github.com:

Thanks, I did the pull request from a fork. And forki did the release. (0.36) Seems to works fine for the devs in my company.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket.VisualStudio/issues/145#issuecomment-336509016, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNIesLQRv0sDecrLm-KA__--FbqkEks5sr5aCgaJpZM4P4JiN .