search

fsprojects / Paket.VisualStudio

Manage your Paket (http://fsprojects.github.io/Paket/) dependencies from Visual Studio!
MIT License
147 stars 51 forks source link

Unsafe overwrites of fsproj file. #69

Open isaacabraham opened 9 years ago

isaacabraham commented 9 years ago

If you do a paket install and have unsaved changes to your project e.g. you added a file and haven't done a build or a save all, your changes will be lost after the projects have been closed and reopened.

forki commented 9 years ago

I thought we already save it. Damn it.

smoothdeveloper commented 8 years ago

This is fixed by #88 I think.

I think the behaviour of unloading / reloading projects is cumbersome on big solutions, because it will close all your open documents and it also takes longer than just having the project changed and Visual Studio prompting for reloading those.

Ideally the logic would add the dependencies within VS in the same way it works when you use "add reference" in the project explorer (alas, I'm unsure if it allows to put additional true in the xml.

This probably requires significant work and maybe dealing with paket internals while the simpler solution to not unload/reload projects would improve the usability from my perspective and don't cost much time to implement.

forki commented 8 years ago

There is no way that I want to deal with VS apis for project manipulation ;-) On Jan 7, 2016 9:26 PM, "Gauthier Segay" notifications@github.com wrote:

This is fixed by #88 https://github.com/fsprojects/Paket.VisualStudio/pull/88 I think.

I think the behaviour of unloading / reloading projects is cumbersome on big solutions, because it will close all your open documents and it also takes longer than just having the project changed and Visual Studio prompting for reloading those.

Ideally the logic would add the dependencies within VS in the same way it works when you use "add reference" in the project explorer (alas, I'm unsure if it allows to put additional true in the xml.

This probably requires significant work and maybe dealing with paket internals while the simpler solution to not unload/reload projects would improve the usability from my perspective and don't cost much time to implement.

— Reply to this email directly or view it on GitHub https://github.com/fsprojects/Paket.VisualStudio/issues/69#issuecomment-169795743 .

smoothdeveloper commented 8 years ago

Would it make sense to then just remove the unload / reload project stuff? On my end I get quicker result and back to work when I run paket install outside of VS and reload all projects than while doing it from VS which closes all my open documents and freezes VS a good deal of the time.

forki commented 8 years ago

yeah that's the workflow I do.

(if you don't reload then the project is basically broken)