"install" update github references v2

[vbfox]

Description

This is exactly the same issue as #1762 but in a slightly different case.

The bug where a change happening but wasn't needed is fixed but only when no change need to happen. If any change need to happen the bug reappear.

Repro steps

Same as the previous bug except that before .paket\paket.exe install the paket.dependencies need to be changed.

Any modification that force a re-creation of the paket.lock seem to do it, simply adding a new nuget package or git repository do it. My real usecase was adding this line to ionide-vscode-paket :

git git@github.com:vbfox/ionide-fsgrammar.git paket-grammars

But I also tried adding a nuget dependency and it trigger the bug.

Related information

v3.3.5

[forki]

this is actually much harder to do. selective update on github files is not supported yet

[vbfox]

There's no hurry ;-)

My question would be why did an update trigger at all ? The behavior for nuget packages is that when paket install is executed and their line in paket.dependencies hasn't been updated (And nothing in the dependency graph force the current locked version to change obviously) then the locked version won't change.

What I mean is that Octokit not updating to 0.20 while the github was updated is a missing feature / bug (That I don't find so important) But I feel like the fact that the locked version changed at all is a bigger problem, the lock file add stability but this stability is lost if a seemingly innocuous change like adding a new package without any dependency can force a locked version to be updated.

[forki]

I think the correct fix is https://github.com/fsharp/FAKE/commit/911c3efbc9127d52b1db0dc0ed6e12aafd23d548

[vbfox]

I don't agree :( The lock file shouldn't have changed

[vbfox]

I'll pop on the gitter, might be easier to discuss this than via github issue comments