fsprojects / Paket

A dependency manager for .NET with support for NuGet packages and Git repositories.
https://fsprojects.github.io/Paket/
MIT License
2.02k stars 525 forks source link

Paket: 5.92.0-alpha001 fail to generate correct project.assets.json #2680

Closed MangelMaxime closed 7 years ago

MangelMaxime commented 7 years ago

I just updating one of my project to use NETStandard 2.0.

When using paket 5.92.0-alpha001 I got this project.assets.json which is wrong. It does not contains my dependencies.

If I use paket 5.91.0, then I got this file.

As you can see the first file is missing a lot of deps like Fable.Core.

Here is my paket.dependencies:

framework: netstandard2.0

source https://www.nuget.org/api/v2

nuget Fable.Core prerelease
nuget Fable.Elmish.React
nuget Fable.Elmish.Browser
nuget Fable.Elmish.Debugger
nuget Fable.PowerPack
nuget Fable.React prerelease

clitool dotnet-fable prerelease

group Build
framework: net46

    source https://nuget.org/api/v2
    nuget FSharp.Core  redirects:force, content:none
    nuget FAKE

    github fsharp/FAKE modules/Octokit/Octokit.fsx

Paket.references:

Fable.Core
Fable.React

Please tell me if you need more infos.

matthid commented 7 years ago

Yes

MangelMaxime commented 7 years ago

Hello @matthid you can find the project here.

To summarize I go the following layout:

/.paket/paket.exe
/paket.lock
/paket.dependencies
/src/Fulma/paket.reference
/src/Fulma/Fulma.fsproj

Here is my Fulma.fsproj.netstandard2.0.references file.

And here is my full obj folder: obj.zip

There is no warning output during my build process by paket. output.txt

matthid commented 7 years ago

Ah good, will try to reproduce later

matthid commented 7 years ago

Ok can you tell me for idiots what I need to do :)

Assume I don't have any idea of fable and just cloned your repository, how do I reproduce the bug?

matthid commented 7 years ago

Problem is all your files look correct, but from your error description it looks like they are never actually read in the build process. Something is wrong there.

matthid commented 7 years ago

OK I noticed something: Your Paket.Restore.targets is not the latest one and paket install didn't update it either. Now I have two questions:

matthid commented 7 years ago

Ah OK its because I removed the old file when only netstandard20 is there (We discussed that it is safe to assume it only is required for fable compat when using netstandard16). Maybe we need to revisit that for at least a couple of versions... (until we can assume people have updated their targets files?)

/cc @forki because of compat concerns

forki commented 7 years ago

I always tried to keep paket backwards compatibility with the old targets files. It's not easy,...

Am 28.08.2017 18:35 schrieb "Matthias Dittrich" notifications@github.com:

Ah OK its because I removed the old file when only netstandard20 is there (We discussed that it is safe to assume it only is required for fable compat when using netstandard16). Maybe we need to revisit that for at least a couple of versions... (until we can assume people have updated their targets files?)

/cc @forki https://github.com/forki because of compat concerns

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2680#issuecomment-325405301, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNJm0ytq2DhgFrLw3U6wy0Ltpv8MTks5scuxlgaJpZM4PEhGB .

matthid commented 7 years ago

Will be fixed with https://github.com/fsprojects/Paket/pull/2684, thanks for reporting and testing the alpha!

MangelMaxime commented 7 years ago

Thanks for the quick fix :)

MangelMaxime commented 7 years ago

I tested with 5.92.0-beta001 and it's working. 👏