search

fsprojects / Paket

A dependency manager for .NET with support for NuGet packages and Git repositories.
https://fsprojects.github.io/Paket/
MIT License
1.99k stars 520 forks source link

adding RuntimeIdentifiers to the fsproj breaks the build #2964

Open coolya opened 6 years ago

coolya commented 6 years ago

Description

I came across some really strange behaviour when using paket and dotnet core together with RuntimeIdentifiers.

Repro steps

Please provide the steps required to reproduce the problem

  1. Create a new hello world fsproj

  2. add a RuntimeIdentifiers section to the file:

    <RuntimeIdentifiers>ubuntu.16.04-arm;ubuntu.14.04-arm</RuntimeIdentifiers>

  1. run paket install

  2. run dotnet build

Expected behavior

build is successful.

Actual behavior

build fails with error message:

/Users/kdummann/source/rubecula/frontend/backend/backend.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-arm'.
/Users/kdummann/source/rubecula/frontend/backend/backend.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetHostPolicy (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-arm'.
/Users/kdummann/source/rubecula/frontend/backend/backend.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetHostResolver (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-arm'.
/Users/kdummann/source/rubecula/frontend/backend/backend.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetAppHost (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-arm'.
/Users/kdummann/source/rubecula/frontend/backend/backend.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-arm'.
/Users/kdummann/source/rubecula/frontend/backend/backend.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetHostPolicy (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-arm'.
/Users/kdummann/source/rubecula/frontend/backend/backend.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetHostResolver (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-arm'.
/Users/kdummann/source/rubecula/frontend/backend/backend.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetAppHost (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-arm'.

The behaviour is not arm specific it also happens for x64 and x86.

Known workarounds

do not use paket to do nuget handling. Simply removing the restore targets file from the fsproj file is enough. Run dotnet restore or dotnet build. Then add the paket restore targets again and everything works. This seems to fix it for the whole machine. The problem is more in CI where we run each build in a new container and as a workaround have to run dotnet restore in a dummy project to get the code building.

forki commented 6 years ago

/cc @enricosada @matthid

matthid commented 6 years ago

Can you just for fun try with setting the environment variable PAKET_DISABLE_RUNTIME_RESOLUTION to false? I guess (I have honestly no idea) this is because of those magic runtime dependencies, because: We don't know about them by default + We prevent NuGet to download stuff (ie everything going to the internet is done by paket).

coolya commented 6 years ago

I tried it but seems to have no effect:

root@6e8f0348d91b:/build# export PAKET_DISABLE_RUNTIME_RESOLUTION=false
root@6e8f0348d91b:/build# echo $PAKET_DISABLE_RUNTIME_RESOLUTION
false
root@6e8f0348d91b:/build# dotnet build
Microsoft (R) Build Engine version 15.5.179.9764 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

perl : warning : Setting locale failed. [/build/fsharp.fsproj]
perl : warning : Please check that your locale settings: [/build/fsharp.fsproj]
    LANGUAGE = (unset),
    LC_ALL = "en_US.UTF-8",
    LANG = "en_US.UTF-8"
      are supported and installed on your system.
perl : warning : Falling back to the standard locale ("C"). [/build/fsharp.fsproj]
  adc83b19e793491b1c6ea0fd8b46cd9f32e592fc
perl : warning : Setting locale failed. [/build/fsharp.fsproj]
perl : warning : Please check that your locale settings: [/build/fsharp.fsproj]
    LANGUAGE = (unset),
    LC_ALL = "en_US.UTF-8",
    LANG = "en_US.UTF-8"
      are supported and installed on your system.
perl : warning : Falling back to the standard locale ("C"). [/build/fsharp.fsproj]
  adc83b19e793491b1c6ea0fd8b46cd9f32e592fc
perl : warning : Setting locale failed. [/build/fsharp.fsproj]
perl : warning : Please check that your locale settings: [/build/fsharp.fsproj]
    LANGUAGE = (unset),
    LC_ALL = "en_US.UTF-8",
    LANG = "en_US.UTF-8"
      are supported and installed on your system.
perl : warning : Falling back to the standard locale ("C"). [/build/fsharp.fsproj]
  adc83b19e793491b1c6ea0fd8b46cd9f32e592fc
perl : warning : Setting locale failed. [/build/fsharp.fsproj]
perl : warning : Please check that your locale settings: [/build/fsharp.fsproj]
    LANGUAGE = (unset),
    LC_ALL = "en_US.UTF-8",
    LANG = "en_US.UTF-8"
      are supported and installed on your system.
perl : warning : Falling back to the standard locale ("C"). [/build/fsharp.fsproj]
  adc83b19e793491b1c6ea0fd8b46cd9f32e592fc
  Restoring packages for /build/fsharp.fsproj...
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-arm'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetHostPolicy (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-arm'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetHostResolver (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-arm'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetAppHost (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-arm'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-x64'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.DotNetHostPolicy (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-x64'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.DotNetHostResolver (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-x64'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.DotNetAppHost (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.14.04-x64'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-arm'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetHostPolicy (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-arm'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetHostResolver (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-arm'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-arm.Microsoft.NETCore.DotNetAppHost (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-arm'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-x64'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.DotNetHostPolicy (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-x64'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.DotNetHostResolver (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-x64'.
/build/fsharp.fsproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.DotNetAppHost (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/ubuntu.16.04-x64'.
  Restore failed in 153.31 ms for /build/fsharp.fsproj.
forki commented 6 years ago

do you have a minimal repro?

coolya commented 6 years ago

will create sample on the weekend, this week is quite busy.

EelcoMulder commented 6 years ago

I have the same issue, only not local but building on VSTS, so I can provide a build log if you want. It does download some runtime files but fails on the same files mentioned above but for win-x64.

2018-01-12T09:05:17.5158152Z d:\a\1\s\Wotzj.Api\Wotzj.Api.fsproj : error NU1100: Unable to resolve 'runtime.win-x64.Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/win-x64'. 2018-01-12T09:05:17.5159868Z d:\a\1\s\Wotzj.Api\Wotzj.Api.fsproj : error NU1100: Unable to resolve 'runtime.win-x64.Microsoft.NETCore.DotNetHostPolicy (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/win-x64'. 2018-01-12T09:05:17.5160835Z d:\a\1\s\Wotzj.Api\Wotzj.Api.fsproj : error NU1100: Unable to resolve 'runtime.win-x64.Microsoft.NETCore.DotNetHostResolver (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/win-x64'. 2018-01-12T09:05:17.5162812Z d:\a\1\s\Wotzj.Api\Wotzj.Api.fsproj : error NU1100: Unable to resolve 'runtime.win-x64.Microsoft.NETCore.DotNetAppHost (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/win-x64'.

coolya commented 6 years ago

I have create a repo to reproduce. I also added a workaround to the readme file:

https://github.com/coolya/paket-problem

coolya commented 6 years ago

I investigated a bit more and it seems that it works with sdk 2.0.0 but fails with the latest SDK.

forki commented 6 years ago

/cc @enricosada @cartermp

Am 14.01.2018 18:07 schrieb "Kolja Dummann" notifications@github.com:

I investigated a bit more and it seems that it works with sdk 2.0.0 but fails with the latest SDK.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fsprojects/Paket/issues/2964#issuecomment-357526110, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNHo2RY01pHoe4AaGHZ3-19NFeeH0ks5tKjRFgaJpZM4RUfBb .

cartermp commented 6 years ago

Do you see this same issue with no paket as well?

coolya commented 6 years ago

Nope, then it works fine. It also works once a projects that doesn't use paket has done a dotnet restore. There must be some machine wide cache or something where it looks up these runtime dependencies.

granttrevor commented 6 years ago

Just struck and thankfully found this Issue log using paket with in a csproj.

dotnet restore was throwing errors like:

error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.NETCore.App (>= 2.0.0)' for '.NETCoreApp,Version=v2.0/linux-x64'

Removing the paket target, restoring and then adding the paket target back in has gotten past it for now.

forki commented 6 years ago

I added a workaround in the Paket.Restore.targets file until we have a proper solution. Please retry with that

matthid commented 6 years ago

Yes I see this as well in Fake after updating .net SDK and the sln file (which visual studio did automatically) https://travis-ci.org/fsharp/FAKE/builds/334104618?utm_source=github_status&utm_medium=notification

So in particular after https://github.com/fsharp/FAKE/pull/1763/commits/56c07fc00d6ccc1aad8ddaf97b055bb52cef3dcb and https://github.com/fsharp/FAKE/pull/1763/commits/080e274087f579c0ff6a3711e33d13b239522d3b