search

fsprojects / Paket

A dependency manager for .NET with support for NuGet packages and Git repositories.
https://fsprojects.github.io/Paket/
MIT License
1.99k stars 520 forks source link

Do not append TargetFramework subdirectory to OutputPath #4159

Closed legrab closed 2 years ago

legrab commented 2 years ago

when AppendTargetFrameworkToOutputPath property is false

The change has not been tested

This commit is meant resolve issue #4157

legrab commented 2 years ago

@forki could you, please, take a look if and how this change could follow coding conventions?

forki commented 2 years ago

since it's untested I released it as 7.2.0-alpha001 - please test it. thanks

legrab commented 2 years ago

I have tested the 7.2.0-alpha001 with and without the AppendTargetFrameworkToOutputPath on this sample repo: https://github.com/legrab/paket_4157

Both cases work as expected; the package is created whether the assembly is built into the subdir or not.

legrab commented 2 years ago

I will add a test case to check the newly supported configuration to OutputSpecs.fs, hopefully in a few days.

legrab commented 2 years ago

I have created an additional PR for testing the change: https://github.com/fsprojects/Paket/pull/4162

legrab commented 2 years ago

@forki Is there any chance that we could have a proper release containing the changes? Or a more extensive test may be required?