search

fsprojects / Paket

A dependency manager for .NET with support for NuGet packages and Git repositories.
https://fsprojects.github.io/Paket/
MIT License
1.99k stars 520 forks source link

Add net481 support #4227

Closed ChrSteinert closed 7 months ago

ChrSteinert commented 9 months ago

This aims to add support for net481 framework restriction, and thus resolve #4224 .

The required change seems to be more intricate, than what has changed so far. For instance, there is something about the NuGetPackageCache.CurrentCacheVersion, that I am not sure about, what to do. It also touched a lot of moving parts (and tests) that I adjusted straight forward, and might be missing some things.

Therefore any advice is apreciated.

smoothdeveloper commented 9 months ago

@ChrSteinert could you add one test similar to tests/Paket.Tests/DependenciesFile/ParserSpecs.fs

Otherwise, if CI gives similar output as #4219, I think we can move this forward.

smoothdeveloper commented 9 months ago

also this one: tests/Paket.Tests/Versioning/PlatformMatchingSpecs.fs

smoothdeveloper commented 9 months ago

@forki, I checked the flakytests CI outputs, they look similar to #4219 AFAICS (beside it pulls dotnet 7 instead of 6).

The added tests cover the support for 4.8.1, I think it is good to go in prerelease mode.

ChrSteinert commented 9 months ago

Thanks for your guidance and review!

Von: Gauthier Segay @.> Gesendet: Thursday, September 28, 2023 7:43:04 AM An: fsprojects/Paket @.> Cc: Christian Steinert @.>; Mention @.> Betreff: Re: [fsprojects/Paket] Add net481 support (PR #4227)

@forkihttps://github.com/forki, I checked the flakytests CI outputs, they look similar to #4219https://github.com/fsprojects/Paket/pull/4219 AFAICS (beside it pulls dotnet 7 instead of 6).

The added tests cover the support for 4.8.1, I think it is good to go in prerelease mode.

— Reply to this email directly, view it on GitHubhttps://github.com/fsprojects/Paket/pull/4227#issuecomment-1738509053, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACLJHRKANBXHXLBQETVCCYDX4UE6RANCNFSM6AAAAAA5FZWKA4. You are receiving this because you were mentioned.Message ID: @.***>

smoothdeveloper commented 7 months ago

/run merge.and.ship.it