search

fsprojects / ProjectScaffold

A prototypical .NET solution (file system layout and tooling), recommended for F# projects
http://fsprojects.github.io/ProjectScaffold
The Unlicense
515 stars 154 forks source link

Fix GenerateDoc failed in Mono (macos) #313

Closed zaaack closed 6 years ago

zaaack commented 6 years ago

When I run ./build.sh in macos, I got an error:

Mono.CSharp.InternalErrorException: Failed to import assembly `Argu, Version=3.3.0.0, Culture=neutral, PublicKeyToken=null' ---> System.ArgumentException: Value does not fall within the expected range.

After digging a while, I find this issue: https://github.com/fsprojects/FSharp.Formatting/issues/412 nothing helped. But when I git cloned the FSharp.Formating repo and built, it didn't fail, so I upgrade the dep in ProjectScaffold, succeed!

dsyme commented 6 years ago

Looks like we have a CI build failure https://travis-ci.org/fsprojects/ProjectScaffold/builds/276515141#L1869

zaaack commented 6 years ago

@dsyme I see the failure, looks like github forbided the CI server's IP, I can access the url with 200 in my PC. But not sure why, maybe it's a day-limit, it's OK now. ; )

dsyme commented 6 years ago

Isn't this a bit big of a change? Using the beta implies that there are potentially breaking changes. In FSharp.Formatting there is a need to do migration from v2 to v3.

Yes, though the scaffold evidently is building on MacOS. Isn't using a beta OK considering the scaffold only gets used for new projects?

wallymathieu commented 6 years ago

Indeed. As a later note, it would be nice to move over to the latest FSharp.Formatting API changes: https://github.com/fsprojects/FSharp.Formatting/blob/master/docs/content/upgrade_from_v2_to_v3.md

wallymathieu commented 6 years ago

So then, can this PR be accepted and merged @dsyme ?