search

fsprojects / SQLProvider

A general F# SQL database erasing type provider, supporting LINQ queries, schema exploration, individuals, CRUD operations and much more besides.
https://fsprojects.github.io/SQLProvider
Other
572 stars 146 forks source link

[HACK] Replace references to `None` basetype to `Some typeof<obj>` #611

Closed rudihorn closed 5 years ago

rudihorn commented 5 years ago

This is a PR to solve the issue I mention in #575. Somehow my editor is configured to automatically remove trailing spaces so it has done this automatically upon saving the file as well.

Essentially this PR replaces all values of None for the basetype value of ProvidedTypeDefinition to Some typeof<obj>. To me this seems like a hack as there seems to be something fundamentally wrong with type resolution with .NET Core and F#, as there seems to be countless projects with similar issues revolving library resolution, but this is a hack which somewhat fixes it for SQLProviders for the moment.

It would be nice if this could be pulled soonish, as the fsharp language server doesn't seem to like loading SQLProviders from a locally saved project but I think it handles the nugget version reasonably.

Thorium commented 5 years ago

Thanks!

Thorium commented 5 years ago

Released in NuGet version 1.1.62

rudihorn commented 5 years ago

Thanks!