Fixes error for netstandard where it tries to load SqlClient 4.6.1.0

JordanMarr commented 3 years ago

Proposed Changes

In reference to issue #645 where a .NET Core project fails with an error message about not being able to load System.Data.SqlClient Version=4.6.1.0 - and also my similar issue where the SSDT Provider gives the same error from VS Code (but not in VS 2019): this change to the build script fixes the issue for me in VS Code.

Types of changes

What types of changes does your code introduce to SQLProvider? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] Build and tests pass locally
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Further comments

This just copies the netstandard2.0 version of System.Data.SqlClient instead of net461 to the bin/netstandard2.0 output folder.

Thorium commented 3 years ago

A few questions, please:

Will this break Visual Studio 2017/2019 which are running fsx on .NET framework rather than dotnet?
Also there has been some issues with System.Data.SqlClient on .Net Core 3.1, that's why they started to do Microsoft.Data.SqlClient.dll, and I think the package versions SQLProvider refernces, System.Data.SqlClient works on .NET and Microsoft.Data.SqlClient works on .Net Core. I've not followed the recent changes on those projects. See https://github.com/fsprojects/SQLProvider/issues/645#issuecomment-639163535

JordanMarr commented 3 years ago

You're right, this just makes it break in different ways.

Thorium commented 3 years ago

That's not the target but the source...

On Thu, 11 Feb 2021, 19:53 Thijs Tijsma, notifications@github.com wrote:

Would it make sense to copy it to both places as a workaround?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fsprojects/SQLProvider/pull/708#issuecomment-777749189, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABX7257VFYKVRIOYKCUSPDS6QYUPANCNFSM4V6MQPTQ .

fsprojects / SQLProvider