search

fsprojects / TickSpec

Lean .NET BDD framework with powerful F# integration
Apache License 2.0
133 stars 23 forks source link

Enable .NET Framework features again. #28

Closed mchaloupka closed 5 years ago

mchaloupka commented 5 years ago

The .NET Framework features (ScenarioGen and FeatureGen) were commented out for .NET Core but the used definition was missing for .NET Framework. So, the code was actually never used. This is returning it back.

michalkovy commented 5 years ago

Wasn't this actually broken by upgrade to .NET 4.5.2? I think we should either use define NET452 or start using new define which is version independent like NETFRAMEWORK

mchaloupka commented 5 years ago

Wasn't this actually broken by upgrade to .NET 4.5.2?

No

I think we should either use define NET452 or start using new define which is version independent like NETFRAMEWORK

NETFRAMEWORK sounds good to me.

michalkovy commented 5 years ago

I still don't agree with your evaluation what it broke, see: https://docs.microsoft.com/en-us/dotnet/standard/frameworks#how-to-specify-target-frameworks

mchaloupka commented 5 years ago

Hmm, I have tried it and maybe I missed one of the definitions. See the updated variant.