search

fsprojects / TickSpec

Lean .NET BDD framework with powerful F# integration
Apache License 2.0
133 stars 23 forks source link

feat(PlaceholdersInTables): Placeholder replacements (from Examples) … #47

Closed deyanp closed 3 years ago

deyanp commented 3 years ago

…also in tables

deyanp commented 3 years ago

Note: Implemented only for tables ..

mchaloupka commented 3 years ago

Hi,

thanks for the PR, it looks good! I am fine with merging it as it is but would you mind adding the support also to other step arguments like doc string and bullets. It feels that it can be part of the same unit test and it would not require significant change of code.

Regards, Milos

deyanp commented 3 years ago

Sure, will do

deyanp commented 3 years ago

and now with the rest as well ... if ok, when can we have a new nuget version, so that we can use it in our slns?

mchaloupka commented 3 years ago

@bartelink Do you have any further comment? If not, I will merge it and create a minor release so it is ready to be used.

bartelink commented 3 years ago

No, in general the impl looks good and has tests so no objections from me (I've not run it or anything though ;))