fsprojects / fantomas-for-vs

Visual Studio Formatter for F#
https://marketplace.visualstudio.com/items?itemName=asti.fantomas-vs
46 stars 10 forks source link

Add support for VS2022. #19

Closed kxxt closed 3 years ago

kxxt commented 3 years ago

This pull request fixes #16.

dsyme commented 3 years ago

Hi @deviousasti,

@KathleenDollard and myself would like to use fantomas direct in VS2022. Is your plan to accept this PR and first do a simple update to this extension? And then doing the re-engineering to use the dotnet fantomas --daemon approach mentioned by @nojaf here? Or go straight to the re-engineering?

thanks! don

deviousasti commented 3 years ago

I've shipped a release of it for VS22 in the marketplace. Hurray. https://marketplace.visualstudio.com/items?itemName=asti.fantomas-vs22

@dsyme The plan was to migrate to Fantomas.Client since it was a major change, but I don't think I'd be able to complete that and ship by VS '22 launch (November 9th). Peak season at work!

@kxxt Thank you for this PR. Could you just pull the changes I've made on top of your PR and update the branch? https://github.com/deviousasti/fsharp-formatting-for-vs/tree/pr/19-add-support-for-vs2022

The changes are:

Thank you for doing all the leg-work. This is the kind of help that makes me glad to be a part of OSS.

kxxt commented 3 years ago

@deviousasti I've rebased my branch onto pr/19-add-support-for-vs2022. 🎉

deviousasti commented 3 years ago

@kxxt Thank you very much! I hope I can finish up #21 soon.