fsprojects / fantomas-for-vs

Visual Studio Formatter for F#
https://marketplace.visualstudio.com/items?itemName=asti.fantomas-vs
46 stars 10 forks source link

Bump Fantomas.Client from 0.4.0 to 0.9.0 in /src/FantomasVs.VS2022 #51

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps Fantomas.Client from 0.4.0 to 0.9.0.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
deviousasti commented 1 year ago

@nojaf there was a new cursor position parameter - I added it. I assume it's supposed to be enable Response.Cursor - I'm currently translating the current caret position from current to applied diff -

            args.TextView.Caret.MoveTo(
                caret
                .BufferPosition
                .TranslateTo(buffer.CurrentSnapshot, PointTrackingMode.Positive)
            );

It generally works well. In the example, it sticks to the then token after format. fantomas-fmt

Should I upgrade it to use response.Cursor - is it stable now?

nojaf commented 1 year ago

Hi there, first of all, thank you for your contributions to this project, they are greatly appreciated. I understand that you had a question, and while I'm happy to help, I just wanted to kindly ask if you could please try to search for the answer on your own first, before tagging me directly. It would save both of us some time and effort. I believe that the v6 issue (which addresses the dedicated cursor issue) and the changelog are actually quite easy to find.

Should I upgrade it to use response.Cursor - is it stable now?

Yes, should be fine.

deviousasti commented 1 year ago

🙏 My bad, my bad.
I remember seeing some initial code went in for Cursor support - but completely didn't check if Rider had integrated it. It's on me. I'll try not to tag you. :)