fsprojects / fantomas

FSharp source code formatter
https://fsprojects.github.io/fantomas
Other
770 stars 191 forks source link

Use F# compiler from the source files #2217

Closed nojaf closed 2 years ago

nojaf commented 2 years ago

As mentioned in https://github.com/fsprojects/fantomas/issues/2160, we would no longer use the FCS version on Nuget of the compiler. Instead, we would grab the files we require from source and build our own little FCS layer that only exposes the F# parser.

Pros

Cons

baronfel commented 2 years ago

One open question that we would need to solve would be the integration story with editors. For editors that host fantomas out-of-process, like FSAC, there's no problems.

For VS/Rider, though, there are hurdles:

nojaf commented 2 years ago

For VS/Ionide nothing really would change there. I believe the impact for Rider will also be minimal. They are also formatting out of process and would only need to address the dependencies for loading the Fantomas.dll. @DedSec256 any thoughts?

auduchinok commented 2 years ago

In Rider we already bundle separate FCS builds for Fantomas and the rest of F# tooling, so it wouldn't change much for us.