Backticks in optional parameter gets removed

[jindraivanek]

Issue created from fantomas-online

Code

type C() =
    static member foo(?``type``) = ``type``

Result

type C() =
    static member foo(?type) = ``type``

Problem description

Backticks removed in ?type - incorrect code.

Probably related to #2731.

Extra information

• [x] The formatted result breaks my code.
• [ ] The formatted result gives compiler warnings.
• [x] I or my company would be willing to help fix this.
• [ ] I would like a release if this problem is solved.

Options

Fantomas main branch at 2023-08-31T06:37:49Z - 369faf81362e7ddb3fce3bd4505216055af35347

Default Fantomas configuration

[nojaf]

Hi there,

We don't process SynPat.OptionalVal correctly in https://github.com/fsprojects/fantomas/blob/bbecd22a6bffd54ea662887366a1b074df5e8c44/src/Fantomas.Core/ASTTransformer.fs#L1633

It should be more something like:

let identNode = mkIdent ident
SingleTextNode($"?{identNode.Text}", patternRange) |> Pattern.OptionalVal

Are you interested in submitting a PR?

[jindraivanek]

Are you interested in submitting a PR?

Yes, it looks simple enough :)