search

fsprojects / fantomas

FSharp source code formatter
https://fsprojects.github.io/fantomas
Other
760 stars 190 forks source link

Use Ionide.Analyzers #2978

Closed nojaf closed 8 months ago

nojaf commented 8 months ago

Trying out https://github.com/ionide/ionide-analyzers

nojaf commented 8 months ago

@dawedawe any thoughts why we are not seeing these warnings?

dawedawe commented 8 months ago

@dawedawe any thoughts why we are not seeing these warnings?

They are at least here: https://github.com/fsprojects/fantomas/security/code-scanning?query=pr%3A2978+tool%3AIonide.Analyzers.Cli+is%3Aopen

To me, it seems a bit like the visual behaviour of GitHub is not really deterministic regarding these things. Maybe the GitHub bot creates comments only for the first PR that adds the code scanning feature 🤷

nojaf commented 8 months ago

I admit defeat when it comes to AnalyzeFSharpProjectUsingFscArgs, I'll explain in more detail in the SDK repository.

Besides that, this is ready for review.