Closed abelbraaksma closed 6 months ago
Hi there,
'6.2.3
does not support while!
, it was introduced in https://github.com/fsprojects/fantomas/blob/main/CHANGELOG.md#630-alpha-002---2023-11-07
Great stuff! I missed it somehow in the changelog. I'll wait for next version :).
Great stuff! I missed it somehow in the changelog. I'll wait for next version :).
Or give the alpha a spin ;) You will most likely find it very stable already.
I thought about that, but I couldn't find docs how to download the alpha in CI (i.e., dotnet tools update
does not seem to pick up alpha versions, even if I specify them). @dawedawe do you know how? And/or where there's instruction to do so?
I would need to update these lines somehow, I guess, or the manifest file: https://github.com/fsprojects/FSharp.Control.TaskSeq/blob/b08c257e5513b9dcc700dc55740858b96f2d7570/.github/workflows/build.yaml#L6
What happens if you do a
dotnet tool update fantomas --prerelease
?
That should give you a
"version": "6.3.0-alpha-004",
inside of the manifest.
Ah, that "just works", awesome! (online there was the suggestion to use --version "*-alpha*"
which did not work for me and I didn't look beyond that).
Thanks for the help 🙇.
small aside - if you use the format 6.3.0-alpha.4
, i.e. with a dot instead of a dash, each piece between periods is treated as a number from the point of view of sorting and hence doesn't need prefixing (yes, there are stone age versions of nuget that don't respect that, but they are long gone.)
No thanks
Issue created from fantomas-online
Code
Result (note: this is expected!)
Problem description
Having something like the above, actually prevents the formatting and when running:
raises the following exception:
I wonder if the "todo" can be ignored somehow. It also seems like work has been done already, as the online tool shows it is formatted without error, so maybe I just have to be patient (but reporting anyway in case someone else encounters this).
Appreciate all the good work as always!!! It is also sooo much faster than, say, a year ago!
Extra information
Live example: https://github.com/fsprojects/FSharp.Control.TaskSeq/actions/runs/7256774972/job/19769562682?pr=209