[Feature request] Set custom fantomas path on Fantomas.Client - Githubissues

fsprojects / fantomas

FSharp source code formatter

https://fsprojects.github.io/fantomas

Other

760 stars 190 forks source link

[Feature request] Set custom fantomas path on Fantomas.Client #3099

Open ratsclub opened 1 week ago

ratsclub commented 1 week ago

I propose we add a way to provide a custom path for fantomas on Fantomas.Client.

As explained on Ionide's discussion, we can't currently have an option to set a custom path for fantomas on VSCode.

Pros and Cons

Pros

The advantages of making this adjustment to Fantomas are ...

Allows the user to freely set where fantomas is located while using VSCode
Nix maintainers can package ionide with fantomas bundled by default (rust-analyzer is an example)

The disadvantages of making this adjustment to Fantomas are ...

More code complexity

Affidavit (please submit!)

Please tick this by placing a cross in the box:

[X] I have read the Contribution Guidelines.
[X] I have searched both open and closed suggestions on this site and believe this is not a duplicate

Please tick all that apply:

[X] This is not a breaking change to Fantomas
[X] I or my company would be willing to help implement and/or test this
[ ] This suggestion is part of the Microsoft style guide (please add a link to section if so)
[ ] This suggestion is part of the G-Research style guide (please add a link to section if so)

nojaf commented 1 week ago

Is it possible to use a version of fantomas specified on the path with your nix thing?

See

https://github.com/fsprojects/fantomas/blob/09635e55f71fc834c4ac2c33381a80f349f472c4/src/Fantomas.Client/FantomasToolLocator.fs#L126-L148