search

fsprojects / fsharp-language-server

Other
219 stars 37 forks source link

Thanks and a few queries #1

Closed tboby closed 6 years ago

tboby commented 6 years ago

Hi, just wanted to say this is an amazing project. I'm working on a language server for a very niche game modding language and this was exactly what I was looking for. A few questions/comments.

  1. This repository is currently unlicensed. Are you ok with me using it in an open-source project? (or under any other terms)
  2. I had no trouble adding server -> client notifications.
  3. I had a little more trouble adding server -> client requests. I ended up using a mailboxprocessor to handle async requests/responses.
  4. I couldn't think of a good way to let the implementing server extend the requests/response/notifications types. Did you have any ideas?

My repository is: https://github.com/tboby/cwtools-vscode Few examples of your server in action: Hover: Hover Diagnostic levels: image

georgewfraser commented 6 years ago

Yeah it's fine, I'll add an MIT license or something at some point.

It's still very much under development...I come back to it periodically. It should be in somewhat better shape today, but it's got a ways to go.

If you fix anything in the LSP implementation, please create a PR.