fsprojects / fsharp-language-server

Other
219 stars 37 forks source link

It is now valid to have a request message with no params #39

Closed mrbech closed 5 years ago

mrbech commented 5 years ago

I have been experimenting with https://github.com/natebosch/vim-lsc where I ran into the issue that it sends a "shutdown" request message with no params which raises an exception in the language server.

Since the specification (https://microsoft.github.io/language-server-protocol/specification) defines params as optional:

params?: Array | object;

I made the change here and tested it with vim-lsc and it works :) As I see it this shouldn't create any issues with other clients.