refactor: Use Snappier library instead of Snappy.Standard

fsprojects / pulsar-client-dotnet

Apache Pulsar native client for .NET (C#/F#/VB)

MIT License

301 stars 47 forks source link

refactor: Use Snappier library instead of Snappy.Standard #266

Closed chriscameron-vertexinc closed 3 months ago

chriscameron-vertexinc commented 3 months ago

My organization has started using Snyk to detect vulnerabilities in repositories. It is complaining that Snappy.Standard, an 8 year old project, is using an ancient version of System.Net.Http with vulnerabilities.

This PR replaces the Snappy.Standard library with the more modern Snappier library.

Lanayx commented 3 months ago

Hi, thank you for the PR! It looks like you've removed array pools, so GC pressure will be high, can you try returning it back for performance purpose? It looks like Snappier does support work with buffers and spans

chriscameron-vertexinc commented 3 months ago

Nevermind, returned it back myself

Thank you so much!!