Push the mark before going to definition (using etags)

fsprojects / zarchive-fsharpbinding

Archive of F# Language Bindings for Open Editors

Other

308 stars 106 forks source link

Push the mark before going to definition (using etags) #993

Closed delexi closed 9 years ago

delexi commented 9 years ago

See discussion for #992.

Going to definition is usually a "bigger" jump - which makes it feasable to push the mark. This allows to go back after looking up a definition of a symbol.

Add fsharp-ac/pop-gotodefn-stack which pops the goto definition stack and thus goes back to where point was before jumping to definition.
This uses etags.
Add key bindings M-. and M-, and C-c C-b to mode map and to menu.
Extend integration test for goto definition.
Readme: convert key bindings list to table and add new key bindings.

rneatherway commented 9 years ago

It looks good apart from the table. The builds are not your fault, I need to check what is going on there.

delexi commented 9 years ago

I amended my old commit with the fixed table.

rneatherway commented 9 years ago

Things work with that change, but for some reason the visit definition call in the background doesn't affect the current buffer when in test mode. I don't understand this behaviour, but this is why your extended test was failing. If you make that change I will merge. Maybe I'll ask on stack exchange if anyone can see why changing files doesn't work.

rneatherway commented 9 years ago

By the way, /= doesn't work for strings (just numbers and markers) in case that comes up again. You should use equal in that case.

delexi commented 9 years ago

I moved the line up and amended the commit!

rneatherway commented 9 years ago

Thanks for this really handy contribution!