fsprojects / zarchive-xamarin-monodevelop-fsharp-addin

(No longer Used) F# Editing Support In MonoDevelop and Xamarin Studio
Other
27 stars 22 forks source link

Another potential NullReferenceException #288

Closed artyomszasa closed 8 years ago

artyomszasa commented 8 years ago

Using fsconfig.DefineConstants.Split(...) generates NullReferenceException if no such tag is present in project file. This have already been fixed in fsconfig.GetDefineSymbols, yet DefineConstants is accessed directly in CompilerArguments.fs.

Using GetDefineSymblos instead removes code duplication (define symbol splitting) and eliminates possibility of NullReferenceException, which caused tooltip initialization to fail.

nosami commented 8 years ago

Thanks! Do you want to remove the commented out code too? If not, I'll do it.