fsr-de / myHPI

Django/Wagtail page serving myhpi.de
https://myhpi.de
11 stars 11 forks source link

Publish docker images with labels #456

Closed frcroth closed 8 months ago

frcroth commented 9 months ago

Possibly Fix #426

Based on https://stackoverflow.com/questions/66017161/add-a-tag-to-a-docker-image-if-theres-a-git-tag-using-github-action

coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7464814675


Totals Coverage Status
Change from base Build 7404061654: 0.0%
Covered Lines: 1276
Relevant Lines: 1715

💛 - Coveralls
jeriox commented 9 months ago

What is the metadata-action used for? (comparing against https://github.com/ephios-dev/ephios/blob/main/.github/workflows/docker.yml). And you probably need the permission stuff to write packages as well

frcroth commented 9 months ago

What is the metadata-action used for? (comparing against ephios-dev/ephios@main/.github/workflows/docker.yml). And you probably need the permission stuff to write packages as well

Ok, the ephios action looks good. How do you use it? Do you create releases via github and then manually start the workflow or do you create tags via git locally and then push them to trigger it? I think it would be best if it automatically ran on release (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release) but I'm not sure if we have the metadata available there.

jeriox commented 9 months ago

We create releases in the GitHub webinterface, and this automatically triggers the workflow and creates the correctly tagged packages (https://github.com/ephios-dev/ephios/pkgs/container/ephios)

frcroth commented 9 months ago

We create releases in the GitHub webinterface, and this automatically triggers the workflow and creates the correctly tagged packages (ephios-dev/ephios/pkgs/container/ephios)

Ok, so just replace the current action with the ephios workflow file?

frcroth commented 8 months ago

@jeriox